Open abetomo opened 4 years ago
https://github.com/atom/node-spellchecker/issues/134
Since obj->Set is an error, we use Nan::Set.
obj->Set
Nan::Set
(#120 also seems to have the same fix in it.)
I thought it would be better to use Nan::Set.
I compiled and ran the unit tests.
Requirements for Contributing a Bug Fix
Identify the Bug
https://github.com/atom/node-spellchecker/issues/134
Description of the Change
Since
obj->Setis an error, we useNan::Set.(#120 also seems to have the same fix in it.)
Alternate Designs
130 is a similar fix.
I thought it would be better to use
Nan::Set.Possible Drawbacks
Verification Process
I compiled and ran the unit tests.
Release Notes