search

atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Wrong curly bracket color #101

Closed umpirsky closed 6 years ago

umpirsky commented 7 years ago

Description

Open { is yellow for class, but gray for methods.

screenshot from 2017-09-20 18-57-42

Steps to Reproduce

This started happening when I upgraded to 1.21.

  1. Open any PHP file (e.g. https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php)

Expected behavior: Both brackets to be of same color.

Actual behavior: See description.

Reproduces how often: Always.

See https://github.com/atom/atom/issues/15624 for more details.

Versions

atom-beta --version
Atom    : 1.21.0-beta1
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0
apm --version
apm  1.18.4
npm  3.10.10
node 6.9.5 x64
python 2.7.12
git 2.7.4
cat /etc/issue
Ubuntu 16.04.3 LTS \n \l
rafaelrenanpacheco commented 7 years ago

Brackets are still yellow in Atom 1.21.1

umpirsky commented 6 years ago

This is the default syntax for Atom editor, right?

higoka commented 6 years ago

Still yellow in 1.22.1

winstliu commented 6 years ago

This is the default syntax for Atom editor, right?

I believe so, yes.

simurai commented 6 years ago

Should be fixed part of Atom 1.24. In the meantime you can add the following to your styles.less file:

// Fix curly brackets in classes (PHP)
.syntax--class.syntax--bracket.syntax--php {
  color: #abb2bf;
}