search

atom / one-dark-syntax

Atom One dark syntax theme
MIT License
443 stars 236 forks source link

Code background color is not same with background color #111

Closed umpirsky closed 6 years ago

umpirsky commented 6 years ago

screenshot from 2018-06-24 13-20-53

As you can see selection and code background color is lighter then background color on the right.

Using Atom 1.28

rsese commented 6 years ago

I think this is a duplicate of https://github.com/atom/one-dark-ui/issues/266, see if my comment here helps /cc https://github.com/atom/one-dark-ui/issues/266#issuecomment-400504501.

For future issues, please use the issue template, the information is super helpful for us when triaging issues.

umpirsky commented 6 years ago

http://blog.atom.io/2018/06/21/atom-1-28.html#support-for-custom-color-profiles fixed it, thanks.

However, this looks like BC break. It should select RGB by default and keep same behavior we had before the upgrade.