This PR changes the colors to look brighter and with higher contrast. Fixes #23
Before:
After:
Initinally this theme was based on https://github.com/atom/base16-tomorrow-dark-theme/ which is a low contrast theme, great for dark enviroments. But now that One dark is the default, its role changed a bit.
Since it's hard to tell in what environment you're are when opening Atom for the first time, it's better to have too high contrast than too low.
When taking a screenshot and adding to a white page, like the docs or here, the white surrounding makes the screenshot seem darker than it would be on a dark background. So making it brighter, counteracts that a bit.
Atom already bundles the lower contrast base16-tomorrow-dark, so people can switch to that, if this one is too bright.
ps. this PR also changes the variable names from colors to more generic names. Like @cyan -> @hue-1. This allows to use different colors in One light but keep the same "logic". Should make it easier to switch between them.
pss. We could also include the other bundled themes to keep the "logic" in sync. Then base16-tomorrow-dark-theme would behave the same as one-dark-syntax, just have different (darker) colors.
This PR changes the colors to look brighter and with higher contrast. Fixes #23
Before:
After:
Initinally this theme was based on https://github.com/atom/base16-tomorrow-dark-theme/ which is a low contrast theme, great for dark enviroments. But now that One dark is the default, its role changed a bit.
base16-tomorrow-dark
, so people can switch to that, if this one is too bright.ps. this PR also changes the variable names from colors to more generic names. Like
@cyan
->@hue-1
. This allows to use different colors in One light but keep the same "logic". Should make it easier to switch between them.pss. We could also include the other bundled themes to keep the "logic" in sync. Then
base16-tomorrow-dark-theme
would behave the same asone-dark-syntax
, just have different (darker) colors.