search

atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Config files: Java Properties and INI Files #33

Closed darylrobbins closed 9 years ago

darylrobbins commented 9 years ago

Update Java Properties file to match YAML and JSON:

screenshot 2015-05-22 05 13 01

I am on the fence about whether I should also update INI files to match the others. So, I haven't committed the INI changes yet.

The default INI colors actually look pretty good together (blue and purple). On the other hand, consistency is always a good thing. I tried the purple in the other config files but it didn't work very well in YAML or JSON. It's really the purple and blue together that make it work for INI.

Here is what INI looks like out of the box right now: screenshot 2015-05-22 05 13 11

And here is what it would look like when made consistent with other config formats: screenshot 2015-05-22 05 13 31

Thoughts?

simurai commented 9 years ago

Blue and purple would match.. on the other hand, my vote goes to red. Because red makes the blue stand out more, which I think is a good thing in this case. And then it matches the rest.

darylrobbins commented 9 years ago

@simurai That's an excellent point! In this case, the contrast between the section headings and the keys is actually working in our favour. We don't want them to just blend together.

I will submit my INI changes in another PR.

I think I may have found an issue in Atom core while digging deeply into file formats: https://github.com/atom/atom/issues/6904

All of my PRs work around these missing classes though so no need for changes; just annoying to be missing them in the first place.

simurai commented 9 years ago

I will submit my INI changes in another PR.

:+1: I merged the color + refactoring branch. So now the variables a more generic. I hope that doesn't mess with a local branch of yours. Here the variables with its meaning as comments: https://github.com/atom/one-dark-syntax/blob/master/styles/colors.less#L13-L28. Good thing is that now the One light theme can be kept easier in sync, so it gets all these changes too.

I think I may have found an issue in Atom core while digging deeply into file formats

Yeah, had those issues as well. Blows up the selectors quite a bit. Might be possible to fix it in the language packages.