search

atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Lots more specs #35

Closed darylrobbins closed 9 years ago

darylrobbins commented 9 years ago
  1. Git Commit Message
  2. SQL
  3. XML
  4. XSLT
  5. HAML
simurai commented 9 years ago

I'm wondering if there is already a collection with sample code for all common languages. Found this: https://github.com/isagalaev/highlight.js/tree/master/test/detect Not sure if we can just take it and use as a flat list. Maybe with permission.

Or the spec should only include languages that get bundled by Atom. https://github.com/atom/atom/blob/master/package.json#L130-L161. Maybe that's not enough.

Also, was thinking that the spec should have first a "typical" code example. So that theme authors can kinda see what it usually looks like. And then at the bottom, there could be tests and edge cases.

darylrobbins commented 9 years ago

Well, that would definitely be easier than coming up with all the examples by hand. :)

highlight.js is released under the BSD license, so we'd be allowed to borrow their code as long as we attributed it back to them and retain the copyright notice. Regardless, I'd still suggest we obtain permission first.

On the subject of only including languages bundled with Atom, I'd say that probably isn't enough. We probably want to focus on looking great with all the bundled languages first but if we want the theme to be useful to the most amount of people, I'd suggest we stray beyond the core language set.

I think we're going to have a pretty difficult time coming up with a "typical" example in many cases. Every individual/organization is going to have their own patterns and practices, which make it difficult to nail down what typical code looks.

simurai commented 9 years ago

I think we're going to have a pretty difficult time coming up with a "typical" example in many cases. Every individual/organization is going to have their own patterns and practices, which make it difficult to nail down what typical code looks.

Yeah, it's less about if the code is correct or if it follows some patterns and practices. Maybe a better word would be a "basic" example. Just so that you don't see only edge cases, but also how syntax looks when it's used in a normal way. Anyways, I might add it to some that I know enough.