atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Add coloring for `support.type` scope (found in python) #36

Closed mehcode closed 9 years ago

mehcode commented 9 years ago

screenshot from 2015-06-03 21 58 01

One Dark

screenshot from 2015-06-03 21 58 13

Atom Dark

simurai commented 9 years ago

@mehcode By support.type, do you mean the int in your example?

If so, it seems that coloring got added through the .support.function scope:

screen shot 2015-07-16 at 6 08 07 pm

mehcode commented 9 years ago

I could have sworn that language-python identified int as .support.type. It now works for python, which is awesome but that was just a case I was using to show an example. I would still like coloring for .support or .support.type. Atom Dark has a color specified for .support.type.

simurai commented 9 years ago

Atom Dark has a color specified for .support.type.

Do you mean here

.support {
  &.type.property-name.css {
    color: #EDEDED;
  }
}

Seems to target CSS property names that are supported:

screen shot 2015-07-17 at 2 52 07 pm

In One dark that gets styled with this.

mehcode commented 9 years ago

I mean here apparently. I've been writing a syntax package and used .support.type to indicate a built-in type and was confused when atom-dark seemed to highlight it but one-dark did not.

.support {
  color: #FFFFB6;
}
simurai commented 9 years ago

I see.. ok, made a PR #41 for .support.type with the same color as functions.

btw. this recent PR https://github.com/atom/language-python/pull/72 is probably the reason int changed from .support.type to .support.function.

mehcode commented 9 years ago

Thank you @simurai