Replace red

[simurai]

Problem: One Dark is originally based on base16-tomorrow which uses red for highlighting (e.g. variables). In base16-tomorrow it's somewhat muted, but in One dark the red is stronger and could make it look like it's some kind of "error".

Ref: https://github.com/atom/language-javascript/issues/263, https://github.com/atom/language-javascript/issues/258

Solution: Replace red with something else.

[winstliu]

Also atom/atom#9562.

[MaximSokolov]

How about highlighting red only variable.language?

[ugajin-nijagu]

I have .variable.other.property.js, .variable.other.object.js, and .entity.name.function.js set to @syntax-text-color. This emulates One Dark with v.0.98.0. In addition I have lightened .punctuation.definition.comment and .comment.line.double-slash so they are easier to read using #888.

[simurai]

How about highlighting red only variable.language?

Do you mean

.variable {
- color: red;
+  &.language {
+    color: red;
+  }
}

Hmmm.. I think .variable { color: someColor; } would still be good to keep. Or at least .variable.other { color: someColor; }

[RiCoTeRoX]

Hi guys.

I changed these classes to have the old styles, maybe it help you

atom-text-editor::shadow span.meta.method-call.js > span.variable.other.object.js { color: #abb2bf; } atom-text-editor::shadow span.meta.method-call.js > span.entity.name.function.js { color: #abb2bf; }

atom-text-editor::shadow span.meta.method-call.js > span.variable.other.property.js { color: #abb2bf; }

atom-text-editor::shadow span.source.js > span.variable.other.property.js { color: #abb2bf; }

[ryanolsonx]

Is this still in the works? Any thoughts on what the red might be replaced with?

[simurai]

Considering the age of this issue, we probably should close it as wontfix. People are very sensitive about "changing what they got used to". It would kinda feel as a different theme/port.