atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Failed to activate the gruvbox theme #56

Closed 7sharp9 closed 8 years ago

7sharp9 commented 8 years ago

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.2.4 System: Mac OS X 10.11.1 Thrown From: one-dark-syntax package, v1.1.1

Stack Trace

Failed to activate the gruvbox theme

At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

LessError: variable @mono-3 is undefined
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

Commands

Config

{
  "core": {
    "themes": [
      "gruvbox",
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
Parinfer, v0.9.0
hyperclick, v0.0.35
minimap, v4.16.2
nuclide-file-watcher, v0.0.35
nuclide-fuzzy-filename-provider, v0.0.35
nuclide-open-filenames-provider, v0.0.35
nuclide-quick-open, v0.0.35
nuclide-recent-files-provider, v0.0.35
nuclide-recent-files-service, v0.0.35
proton-mode, v0.1.0
python-yapf, v0.9.1
relative-numbers, v0.2.4
vim-mode, v0.63.0

# Dev
No dev packages
lee-dohm commented 8 years ago

It looks like the cause for this one is in the config:

{
  "core": {
    "themes": [
      "gruvbox",
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Atom is designed to have only two "themes", a UI theme and a Syntax theme. Adding gruvbox to the list of themes (especially in front of the other two) is screwing up the style initialization code.

simurai commented 8 years ago

Closing this. @7sharp9 Feel free to open a new one if you couldn't resolve this.