atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Too Much Red Syntax Highlighting? #60

Closed lukeschunk closed 8 years ago

lukeschunk commented 8 years ago

I opened Atom today and noticed that my page had a LOT of red on it. I know this wasn't how it was before. For example, in the screenshot, this.props.isLoading should not be all red. I believe only the this was red before?

Any thoughts? screen shot 2016-01-14 at 2 09 05 pm screen shot 2016-01-14 at 2 10 31 pm

winstliu commented 8 years ago

Closing in favor of #54, atom/language-javascript#263, atom/language-javascript#258, and atom/atom#9562.

lukeschunk commented 8 years ago

Fair, but any idea why this would have happened suddenly? I didn't even update today.

winstliu commented 8 years ago

@lukeschunk Atom 1.4.0 was released yesterday, containing many language-javascript changes. Your Atom probably automatically updated when you closed it.

lukeschunk commented 8 years ago

ahh thank you so much that must have been it @50Wliu

RiCoTeRoX commented 8 years ago

Hi @lukeschunk , I changed these classes to have the old styles, maybe it help you

atom-text-editor::shadow span.meta.method-call.js > span.variable.other.object.js { color: #abb2bf; } atom-text-editor::shadow span.meta.method-call.js > span.entity.name.function.js { color: #abb2bf; }

atom-text-editor::shadow span.meta.method-call.js > span.variable.other.property.js { color: #abb2bf; }

atom-text-editor::shadow span.source.js > span.variable.other.property.js { color: #abb2bf; }

marcelombc commented 8 years ago

Revert to version to 0.100.0 or add this styles:

@import 'colors';

atom-text-editor::shadow {
    .variable.other.object.js { color: @mono-1; }
    .variable.other.property.js { color: @mono-1; }
    .meta.method-call.js {
        > .entity.name.function.js { color: @mono-1; }
    }
    .meta.function-call.js {
        > .entity.name.function.js { color: @mono-1; }
    }
}
MaximSokolov commented 8 years ago

@RiCoTeRoX, @marcelombc to revert changes properly add this:

@import "syntax-variables";

// Replace `.theme-one-dark-syntax` with `.theme-{syntax theme name}`
.theme-one-dark-syntax atom-text-editor::shadow .source.js {
  .variable.other.property, .variable.other.object {
    color: @syntax-text-color;
  }

  .meta.function-call, .meta.method-call {
    & > .entity.name.function {
      color: @syntax-text-color;
    }
  }
}
marcelombc commented 8 years ago

@MaximSokolov thank you.

lukeschunk commented 8 years ago

:+1: awesome thanks everyone

RiCoTeRoX commented 8 years ago

thank you @MaximSokolov !

preschian commented 8 years ago

@MaximSokolov thank you~

still love the old one...