search

atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

improve json highlighting #76

Closed gosteev closed 6 years ago

gosteev commented 8 years ago

hello. i work with large json files periodically, and noticed something that i miss in 'one dark syntax' theme. sublime material theme has next json highlighting:

image

this is the same chunk, but in atom with one dark syntax:

image

keys of keys has more saturated red color, and 'root' keys are purple at all. it is not critical, but significantly improves understanding of structure, especially when you are tired.

also - maybe there is a reason to make color of quotes a bit darker, so user could focus more on keys / values, not quotes (example)

BadBastion commented 7 years ago

I know this is a year old, but it can be done.

If Show Indentation Guide is turned on there is one <span class=leading-whitespace indent-guide> per tab. As long as Show Indentation Guide is enabled, using nth-child works.

I will create a pull request to add this support soon.

simurai commented 6 years ago

There is now a PR that adds up to 6 indentation levels: https://github.com/atom/one-dark-syntax/pull/113

I'm still a bit on the edge about it. On the one hand, it can help with indentation, on the other hand, it's harder to see what is a key and what a value because keys can have different colors. Hmmm.. 🤔

Aerijo commented 6 years ago

@simurai I think the change would be very confusing, especially to current users of this theme (I was taken aback when I saw the PR just now).

It would be ideal to have a setting somewhere, but that may be difficult to do cleanly. Alternatively, the colour change could be more subdued, like in the Sublime screenshot. Even then, there will be a few people rasing issues and asking questions about how the theme broke...

simurai commented 6 years ago

Yeah, agreed. I think it a bit too much. For now, let's close this as wontfix.