atom / one-dark-syntax

Atom One dark syntax theme
MIT License
443 stars 236 forks source link

Syntax highlight broken after update #82

Closed ruslankonev closed 7 years ago

ruslankonev commented 7 years ago

In other selected themes – all fine

image

Ben3eeE commented 7 years ago

This is because you have manually installed atom-dark-syntax at some point causing you to get update notifications for this package. This package is only supposed to be updated along with Atom.

You should uninstall the version you have installed using apm uninstall one-dark-syntax which will make it so you use the bundled version instead which is designed for Atom 1.12.

ruslankonev commented 7 years ago

I update theme not manually, I update by notification by Atom. After restart Atom only one-dark-theme & syntax was not highlight any language.

Unfortunately apm uninstall one-dark-syntax & apm install one-dark-syntax will not help me. And after delete Atom with AppCleaner and install his again, syntax in one-dark will not working on any language. Why? What can help me? image

simurai commented 7 years ago

Unfortunately apm uninstall one-dark-syntax & apm install one-dark-syntax will not help me.

@Ben3eeE meant to only uninstall one-dark-syntax and not re-install it after again. So could you try to:

  1. Run apm uninstall one-dark-syntax
  2. Reload Atom

Now Atom will use the right version of one-dark-syntax, the one that is already included (bundled) with Atom.

ruslankonev commented 7 years ago

@Ben3eeE meant to only uninstall one-dark-syntax and not re-install it after again. So could you try to:

And this will not help.. need go to vscode until it does not fix

simurai commented 7 years ago

And this will not help..

Just to be sure.. if you go to "Settings > Themes", do you see one-dark-syntax 1.6.0 under "Community Themes"?

screen shot 2016-11-22 at 9 19 01 pm

apm uninstall one-dark-syntax + reload Atom should remove it so that only one-dark-syntax 1.5.0 under "Core Themes" is installed.

Another option is to try Atom Beta. There one-dark-syntax 1.6.0 should already work.

ruslankonev commented 7 years ago

I have installed only one-dark-syntax 1.5.0, and this version will not highlight language with colors. After update something was going wrong. image

image

ruslankonev commented 7 years ago

Wow, in beta syntax also now working. I think something in local settings or packages was broken

image

ruslankonev commented 7 years ago

In my case I found what happens with editor. Somehow was shutdown language-javascript package — I see what code shown in "Plain Text" mode. In my case issue was closed, but https://github.com/atom/atom/issues/13294#issuecomment-262234540

gusbemacbe commented 7 years ago

But in my Atom, Javascript syntax was still enabled and it wasn't colourful. Check the screenshot and they are still enabled and that file isn't highlighted with colours.

screen shot 2016-11-22 at 11 23 22

simurai commented 7 years ago

Ok, let's move back to https://github.com/atom/atom/issues/13294 :grinning: