atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Add highlight-selected support #83

Closed simurai closed 7 years ago

simurai commented 7 years ago

This restyles the highlight-selected package. Instead of the white border, it just adds blue underlines.

Before

After

highlight-selected

Ref: https://github.com/atom/find-and-replace/issues/820 + https://github.com/atom/find-and-replace/pull/796

simurai commented 7 years ago

Unfortunately I had to revert this again. :sob: For some reason it broke the atom/atom specs. I might take another look later, for now I added the following to my styles.less file.

// Highlight Selected -----------------------------------

atom-text-editor {
  .highlight-selected .region.region.region {
    border-radius: 0;
    border: none;
    border-bottom: 1px solid @syntax-result-marker-color-selected;
  }
  [class="highlight highlight-selected background"] .region.region.region, // TODO: <- Remove when fixed in Core, currently background -> syntax--background
  .highlight-selected.background .region.region {
    background-color: @syntax-result-marker-color;
  }
}
Ben3eeE commented 7 years ago

I have been using this in my stylesheet for a few weeks by now and I love it 💯 thank you so much @simurai! ✨

chrisdrackett commented 7 years ago

@simurai what are you using to put the colored lines in the gutter (green and yellow in the shot above)

simurai commented 7 years ago

@chrisdrackett These lines should be there by default when you make changes and save.

Make sure that git-diff package is not disabled.

image

Also, your project needs to be version controlled with Git. Like when cloning a repo from github.com for example.

chrisdrackett commented 7 years ago

nice, I had the icons on, this is much better :)