atom / one-dark-syntax

Atom One dark syntax theme
MIT License
443 stars 236 forks source link

Change link (url) color to cyan #88

Closed simurai closed 7 years ago

simurai commented 7 years ago

Description of the Change

This changes the link (url) color in Markdown files from purple to cyan.

Benefits

It will be easier to distinguish from italic text.

Before:

2016-12-28 at 7 22 am

After:

screen shot 2017-01-07 at 9 24 27 am

Possible Drawbacks

People like purple more.

Applicable Issues

Closes https://github.com/atom/one-dark-syntax/issues/87

bobrocke commented 7 years ago

If lots of people like purple for URLs, myself included, perhaps use cyan for the italic text, instead.

simurai commented 7 years ago

What if lots of people like purple for italic? :smiling_imp:

The reason why I thought cyan would be a good replacement: Cyan is closer to green (used for the link text) making the text and URL more seen as a group and that they belong together.

screen shot 2017-01-07 at 9 24 27 am

Cyan doesn't "pop/stand out" as much, but I think most people just copy&paste the URL and don't hand edit it that often.

Does that make any sense?

bobrocke commented 7 years ago

Sounds good to me.