atom / one-dark-syntax

Atom One dark syntax theme
MIT License
448 stars 236 forks source link

Imported Elixir syntax highlighting. #94

Closed BadBastion closed 7 years ago

BadBastion commented 7 years ago

Description of the Change

Improved Elixir syntax highlighting

Outcome

See example below.

Alternate Designs

The colors for each group could different. The current color scheme was chosen to minimize the change from Elixir's current highlighting.

Possible Drawbacks

Changing the color scheme will affect people already using One-Dark with Elixir. While the improvements to highlighting consistency will be welcome, there is no guaranty everyone will agree on the color choices.

Applicable Issues

Lambda shorthand &{ &1 } and string interpolation #{ var } highlights as red. While this is exactly the same as it was before, it isn't consistent with red being all "header stuff". Sadly there in no way around this with how atom's elixir language grammars currently work.

Example gktdo8d

BadBastion commented 7 years ago

Is there anything needed to prepare this to be merged into master?

BadBastion commented 7 years ago

@simurai