search

atom / one-light-syntax

Atom One light syntax theme
MIT License
66 stars 72 forks source link

Highlight inline code #13

Closed sbaack closed 8 years ago

sbaack commented 8 years ago

Thanks for this great theme. I write a lot in Markdown and noticed that inline code is not highlighted:

screen shot 2015-09-24 at 8 55 20 pm

It would be great if it could be highlighted, like this (using the Writer syntax theme as an example):

screen shot 2015-09-24 at 8 56 55 pm
simurai commented 8 years ago

Hmm.. Are you sure that the first screenshot is the one-light-syntax theme? I can't reproduce it. In my case inline code gets highlighted as greenish text:

screen shot 2015-09-25 at 11 29 05 am

The Writer theme adds a background. That might be a good idea since in the rendered HTML output it usually also gets a background. Although it might look like a selection.

simurai commented 8 years ago

Ohh.. wait. I just realized that the green highlight got added a 15 days ago: https://github.com/atom/one-light-syntax/pull/11. So it hasn't been released to Atom stable yet.

@sbaack Are you ok with that change?

sbaack commented 8 years ago

That's great, thanks! Looking forward to the release :-) Will this also get fixed for the One-Dark and Base16 themes then?

simurai commented 8 years ago

One dark: Yes Base16 themes: Just now, after you mentioned it. Thanks.

sbaack commented 8 years ago

You're welcome, and thank you again for fixing it. I guess this can be closed then.