atom / one-light-syntax

Atom One light syntax theme
MIT License
68 stars 72 forks source link

Invisible Selection #39

Closed tobb10001 closed 6 years ago

tobb10001 commented 7 years ago

I'm using the One Light Syntax Theme together with the One Light UI Theme and there is no visual difference between the selected and not-selected text.

simurai commented 6 years ago

Can you post a screenshot? Selected text should get a darker background color:

selection

tobb10001 commented 6 years ago

Hello simurai,

I tried to reproduce it and found out it depends on which monitor I am using. Trying it on another one left me with the result you showed in the other post. I'm sorry I reported without testing it another time. However, I found out on my PC selected text is also made bolder with this theme. This was sometimes even einough for me.

Thank you for answering!

simurai commented 6 years ago

Maybe the selection color isn't strong enough to be seen on your first monitor? You could play around with it by adding the following to your styles.less file:

atom-text-editor .selection .region {
  background-color: hsl(240, 10%, 85%);
}

The last number (85%) is how light/dark it should be.

simurai commented 6 years ago

Closing this as wontfix. If higher contrast is needed you can customize selections with the ☝️ above snippet.