search

atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

Increase contrast of VCS colored and focused tree-view #117

Closed simurai closed 6 years ago

simurai commented 6 years ago

Description of the Change

This makes the text color of VCS colored + selected + focused tree-view items white.

Before After
screen shot 2017-12-09 at 5 06 17 pm screen shot 2017-12-09 at 5 05 57 pm

Benefits

Better contrast

Possible Drawbacks

You can't see the VCS coloring while the tree-view is in focus. We could potentially add some colored dot/stripe. But maybe in a separate PR.

Applicable Issues

Follow-up of https://github.com/atom/one-light-ui/pull/114#issuecomment-350065311

50Wliu commented 6 years ago

:+1: this definitely looks better. I wish there was a way to preserve the VCS coloring though without having to resort to dots. What about changing the focused indicator itself to indicate VCS status? Not sure if that would look ok or not.

simurai commented 6 years ago

What about changing the focused indicator itself to indicate VCS status?

Tried that out:

tree-view

How do you like it? I think visually it would look ok, just not sure UX wise? If you're used to focus=blue, seeing a different background color throws you off that expectation.