atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

Standalone status-bar icons not centered #122

Closed 50Wliu closed 6 years ago

50Wliu commented 6 years ago

Prerequisites

Description

By default, the One UI themes give all status bar icons a right-margin of .25em so that they're not pressed against text. However, this also causes standalone status bar icons with no associated text (such as teletype) to appear uncentered.

teletype-uncentered

Expected behavior: Icons with associated text to have a margin; standalone icons or the last icon in the tile to not have a margin.

Actual behavior: All icons have margins.

Reproduces how often: 100%

Versions

Atom    : 1.26.0-dev-b922430c1
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0
simurai commented 6 years ago

Hmm.. that's kinda hard to detect if an icon has no text next to it. There are pseudo selectors like :only-child or :empty, but since every package could have different markup, that only works in some cases.

I guess for now we have to manually override it.