Custom GitHub package inputs - Githubissues

atom / one-light-ui

Atom One light UI theme

MIT License

73 stars 62 forks source link

Custom GitHub package inputs #131

Closed simurai closed 6 years ago

simurai commented 6 years ago

Description of the Change

This PR changes the overlay background color to a mix between the editor and dock background.

Alternate Designs

We could make it darker or even inverted, but since there is no variable for text colors in overlays, text contrast would suffer.

Benefits

Overlays can be differentiated from inputs.

Before	After

Possible Drawbacks

Yet another shade of grey.

Applicable Issues

No issue, but reported by @kuychaco

simurai commented 6 years ago

Also added a focus border:

co-author

Should make it look more like they belong together.