atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

Cannot click on the file in tree view right above ":selected list-item" when enable "Make tree view header sticky", #136

Closed Liby99 closed 6 years ago

Liby99 commented 6 years ago

Prerequisites

Description

For recent days I'm not able to click on the file in tree view above the selected one. The simple walk-around was to click on any other file and then click back to the one I want to open. After opening the inspect element I found that there's an extra style added to the "selected list-item":

[theme-one-light-ui-sticky-headers="sticky"] .tree-view .list-item.selected {
    padding-top: 2.5em;
    margin-top: -2.5em;
}

This is going to make the selected item shift upward 2.5em and has a padding-top 2.5em, and hence the list-item above it is not clickable. I could either disable these styles in inspect element or disable the "Make tree view header sticky" in one-light-ui setting to make the list-item above the :selected one clickable. But I think this is definitely a bug to be fixed.

Steps to Reproduce

  1. Enable the "Make tree view header sticky" in the one-light-ui setting.
  2. Click on files across different folders multiple times.
  3. Click on any file (that is not the first one in the directory) in the tree view except the header and directories.
  4. Try to click on the file above the selected one.

Expected behavior: Click on the file above the selected one will also open that file

Actual behavior: The list-item above the selected one is non-clickable so the user is not able to open that file

Reproduces how often: 70%

Versions

$ atom --version Atom: 1.27.2 Electron: 1.7.15 Chrome: 58.0.3029.110 Node: 7.9.0

$ apm --version APM: 1.19.0 NPM: 3.10.10 Node: 6.9.5 x64

Additional Information

None

rsese commented 6 years ago

Thanks for contributing!

This is a duplicate of https://github.com/atom/one-dark-ui/issues/257 which is fixed as of 1.28 (currently in beta).


Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

https://github.com/atom/one-light-ui/pull/133