atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

Tree view headers become transparent when stickied #139

Closed emroch closed 6 years ago

emroch commented 6 years ago

Prerequisites

Description

The project header in the tree view normally has an opaque background color matching the UI theme. However, when I scroll to the bottom of the tree view, the opaque background goes away and I can see the text of the folder/file names behind the header. If I scroll back up, the background reappears.

Steps to Reproduce

  1. Select One Light UI or One Dark UI
  2. Enable "Make tree-view project headers sticky"
  3. Add a project folder that contains enough entries to cause the tree view to scroll
  4. Scroll slowly through the tree view, paying attention to the project header. It normally goes transparent at the bottom, but occasionally happens in the middle.

Expected behavior: Project header background remains opaque

Actual behavior: Project header background disappears and text from tree-view shows through

Reproduces how often: 100%

Versions

Atom : 1.28.2 Electron: 2.0.5 Chrome : 61.0.3163.100 Node : 8.9.3

apm 1.19.0 npm 3.10.10 node 6.9.5 x64 atom 1.28.2 python 2.7.10 git 2.15.2

macOS 10.13.6

rsese commented 6 years ago

Thanks for the report - I can reproduce in safe mode with 1.31.0-nightly7 on macOS 10.12.6:

sticky-header

It seem like single-clicking something in the tree-view can also make this happen?

sticky-header-part-2

/cc @simurai for πŸ‘“ when you're back, another sticky header issue 🎨

linjialiang commented 6 years ago

@rsese

Project root is not specified z-index

atom-panel-container.left .header.list-item.project-root-header{z-index: 2;}
linjialiang commented 6 years ago

@rsese

I also found a problem The subdirectory overrides the parent directory

1

default

The cause of this problem

default

rsese commented 6 years ago

I also found a problem The subdirectory overrides the parent directory

:+1: I see that behavior in your GIF as well though only after the transparent sticky header issue happens.

linjialiang commented 6 years ago

I think you can maintain only one theme style, so you have more time to maintain it

simurai commented 6 years ago

Thanks @emroch @linjialiang, should be fixed in Atom 1.31.