atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

With status bar extending entire width, there is no visual separator between status-bar and tree-view #55

Closed lee-dohm closed 8 years ago

lee-dohm commented 8 years ago

Even if there is the same background color between the text editor and the status bar, there is the line separating the two, so it is obvious where one ends and the other begins. This isn't the case with the tree-view:

obvious

How I discovered this, is I had a screen that looked like this:

looks-like-tree-view-has-bug

And I thought the tree-view was broken because the last item was missing until I remembered that the status bar extends the width of the window now.

I'm not sure if there is something that should be done about this. Or something good that could be done and still maintain the visual style. But I trust that others know more than I do about these things :grinning:

lee-dohm commented 8 years ago

Oh, and this can only be replicated obviously when there is no text editor open because then it looks like this:

screen shot 2016-03-19 at 10 26 18 am
simurai commented 8 years ago

:+1: We could add a border under the tree-view? And maybe also change the background?

lee-dohm commented 8 years ago

Hmmmm ... I was just playing around with this and it appears that at smaller window sizes, the borders turn into separators. For example there's this small window size:

small-window

And then at a larger window size:

large-window

So maybe just a separator between the tree-view and the status-bar at small sizes and then a border around tree-view, similar to the editor area, at larger window sizes? I think a subtle shade change between the status-bar and the other areas would be good too.

simurai commented 8 years ago

Ya, in "compact" mode, just a border is fine:

screen shot 2016-03-22 at 2 15 44 pm

Then for "spacious" mode, adding a border around the whole tree-view would be an option, but maybe a bit too "heavy"? Alternatively, the border could just fade out at the left side. So it would still feel "airy". Similar to the tabs divider.

screen shot 2016-03-22 at 2 32 14 pm

lee-dohm commented 8 years ago

Yeah, I like that. I think the airy feeling is fine because while I may not normally see it consciously, if I looked closer I would.

simurai commented 8 years ago

Ok, let's merge that. I also tried out separating the status-bar from the editor:

screen shot 2016-03-22 at 2 12 53 pm

But that feels a bit too strong. We might could try it again once the title bar can be styled.