atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

Improve contrast of badges on dark backgrounds #75

Closed simurai closed 8 years ago

simurai commented 8 years ago

Problem: When using a .badge on a background from a dark syntax theme, contrast suffers.

screen_shot_2016-09-19_at_4 18 53_pm_720

Solution: Change the @background-color-selected variable to not use transparency.

It won't look as subtle, but at least it's readable.

screen shot 2016-09-20 at 9 46 43 am

Concerns: I think initially, transparency was used to make it more flexible with different backgrounds, but that only works when they are light too.

matthewwithanm commented 8 years ago

I don't think it's quite that simple…the "hi" message in the example uses .highlight-info.

simurai commented 8 years ago

Right.. the .highlight classes also shouldn't use transparency. Should be fixed in 1.12.

matthewwithanm commented 8 years ago

Thanks! ❤️