atom / one-light-ui

Atom One light UI theme
MIT License
73 stars 62 forks source link

Docks #96

Closed simurai closed 7 years ago

simurai commented 7 years ago

Description of the Change

In anticipation of Atom getting Docks https://github.com/atom/atom/pull/13977, this PR makes some changes, mainly:

Just a single editor

screen shot 2017-03-25 at 4 42 56 pm

All 3 docks open

screen shot 2017-03-25 at 5 16 37 pm

☝️ The style guide and settings-view would also need some updating so they fit better in a more narrow dock. And the linter is "just dragged" inside with the DevTools to get an idea how it would look.

Alternate Designs

Was also considering having different tabs for the center and the docks, but that felt weird.

Benefits

More space for code and dock panes.

Possible Drawbacks

Those that liked the spacious layout mode might won't like this change. There is still the option to increase the UI font size to make everything a bit bigger.

Applicable Issues

Depends on https://github.com/atom/atom/pull/13977

simurai commented 7 years ago

Added an option to hide the toggle buttons:

dock-buttons

rogeriochaves commented 7 years ago

I'm using this for myself:

.tab-bar {
  height: 3.5em;
  .tab {
    line-height: 3.5em;
  }
  .close-icon {
    top: 1em!important;
  }
}
simurai commented 7 years ago

This issue https://github.com/atom/one-dark-ui/issues/198 in the dark version also has some examples how to customize the tabs.

jesseleite commented 7 years ago

Not sure where to post this. I notice it's awkward trying to drag an editor tab to be the leftmost tab, as it often tries to add itself to the tree view as a tab.

Great work on this btw. I really miss the look and feel of the old 'spacious' mode 😢 But I do like the new direction of docks functionality-wise. Interested to see how this evolves 👍

simurai commented 7 years ago

@JesseLeite Great work on this btw. I really miss the look and feel of the old 'spacious' mode 😢 But I do like the new direction of docks functionality-wise. Interested to see how this evolves 👍

Same here. Really like the flexibility that comes with the docks.

I notice it's awkward trying to drag an editor tab to be the leftmost tab, as it often tries to add itself to the tree view as a tab.

Hmmm.. You don't have to drag too close to the tree-view tab. As long as you are over half of the first tab, you're fine. Notice the little arrows pointing left/right. They should give you a clue where the tab will be inserted:

drag

jesseleite commented 7 years ago

I realize that, but is there ever a use case where someone would want to add text editor tabs to the tree-view dock?

50Wliu commented 7 years ago

I think it'll be disallowed starting with https://github.com/atom/atom/pull/14695.

simurai commented 7 years ago

Oh.. I see. Your point is, it shouldn't be allowed at all. Ya, your wish might come true.

Although sometimes I still find it handy. For example having a long list of variables that you can quickly toggle on/off as a reference.