search

atom / settings-view

🔧 Edit Atom settings
MIT License
272 stars 276 forks source link

fix(restart-notification): undefined latestVersion #1057

Closed FalkF closed 5 years ago

FalkF commented 6 years ago

Description of the Change

When installing a package from git url this bug occurs on the first update. The second update shouldn't be affected because the package gets convertet from git style to normal as part of the update.

This PR makes the code for the detail message more robust and adds sha's for git packages:

git-packages git-packages2

closes: #1056

To reproduce the bug reset a git package:

  1. apm install thomaslindstrom/color-picker
  2. cd ~/.atom/packages/color-picker
  3. g stash
  4. g reset --hard a296114f3d0deec519a41f4c62e7fc56075b7f01
  5. g stash pop
  6. replace the sha in package.json

Btw. what is the point of having git packages in the first place, when we convert them after the first update?

lee-dohm commented 6 years ago

Would it be possible for you to add some tests around this functionality? At least the bits that generate the various strings for display?

winstliu commented 5 years ago

Hmm, Appveyor failure looks real.