atom / settings-view

🔧 Edit Atom settings
MIT License
272 stars 275 forks source link

Package author shown in atom package list may not match actual author on atom.io #1118

Closed wesinator closed 5 years ago

wesinator commented 5 years ago

Prerequisites

Description

Package author displayed based on repository in atom packages settings may not match the actual author/publisher on atom.io, can be spoofed.

Steps to Reproduce

  1. This package - https://atom.io/packages/atom-whois View the package in atom Packages search

Expected behavior: Shows actual author of package based on atom.io author

Actual behavior: Package author is shown as being atom, presumably based on the user in the repository field.

image

The package repo URL was set to atom - https://github.com/giovazz89/atom-whois/pull/4

Reproduces how often: 💯

Versions

macOS

Atom    : 1.34.0
Electron: 2.0.16
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.3
lee-dohm commented 5 years ago

@Arcanemagus raised a good point that this can be considered a security issue since obviously this package wasn't published by the Atom team.