Fix unreliable tests - Githubissues

nathansobo commented 5 years ago

This PR attempts intermittent failures of tests that interact with snippets. I think these failures are caused by the following race condition:

The tests activate the snippets package first.
The snippets package loads bundled snippets, then reads all loaded packages in an async function.
The tests then activate the language-test package asynchronously in a waitsFor block.
Most of the time, the waitsFor block runs before the async function that reads loaded packages in the snippets package, but this isn't guaranteed.
If the waitsFor block runs after the async code in the snippets package, snippets from the language-test package are never loaded and the tests fail.

I think this what is happening. Hopefully I am right and CI will pass now. 🤞

nathansobo commented 5 years ago

Force-pushed and updated the PR body with a new hypothesis.

winstliu commented 5 years ago

Thank you!! I've been wrangling with this so much. Should close #973, right?

nathansobo commented 5 years ago

Yep. In the future you should always feel free to just close a linked issue that I miss on your own. Thanks for the heads up though! Closes #973.

atom / settings-view