color .setting-description alignment

the-j0k3r commented 4 years ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

This PR aligns the `.color .setting-description margin-top: -0.5em; pulls the description to about the same distance in e.g. checkbox settings descriptions,

Ive illustrated the description to a gif for visualization of what this PR does.

generic

Alternate Designs

Thought about actually aligning both checkbox and swatches to be middle aligned to settings titles as well as the color settings description fix in the PR Something like (can be tested by adding this to your Atom stylesheet.

.settings-view {
  input[type="checkbox"] {
    margin: 0.21em 0.75em 0 -2.25em;
  }
  .color {
    .setting-description {
      margin-top: -0.5em;
    }
  }
  input[type="color"] {
    margin: 0.313em 0 0 -5em;
  }
}

However the nature of that design choice may stray outside the intended design so I decided against submitting that for this reason. Here it is how that would look.

generic

If that alternate design is preferred let me know.

Benefits

Accounts mainly for color settings description top alignment to label in design.

Possible Drawbacks

🤷‍♂

This proposal was tested with All built in Atom themes and across Windows, macOS, Linux.

Applicable Issues

@lee-dohm as requested on slack

lee-dohm commented 4 years ago

Thanks for submitting this @the-j0k3r!

I'll have the development team take a look 👍

darangi commented 4 years ago

Thanks for the contribution! @the-j0k3r

the-j0k3r commented 4 years ago

You're very welcome. =)

atom / settings-view