atom / settings-view

šŸ”§ Edit Atom settings
MIT License
272 stars 276 forks source link

New Pane is not auto focused #1164

Open johnpaulmedina opened 4 years ago

johnpaulmedina commented 4 years ago

Prerequisites

Description

When using the keyboard command to install a package the new pane does not autofocus to the input. Requires using the mouse to select the search field. Keyboard bindings should keep us at the keyboard for faster productivity.

Steps to Reproduce

  1. CMD+SHIFT+P
  2. Choose the action Install Package

Expected behavior:

The opened pane window should be focused

Actual behavior:

Open pane window does not autofocus

Reproduces how often:

100%

Versions

Atom : 1.49.0 Electron: 5.0.13 Chrome : 73.0.3683.121 Node : 12.0.0 apm 2.5.0 npm 6.14.5 node 10.20.1 x64 atom 1.49.0 python 2.7.16 git 2.24.3

CarolineS-QA commented 4 years ago

This issue should probably be moved to atom/settings-view as it's the relevant package.

I found an old but simular issue regarding keybindings instead of install packages atom/settings-view issue 1083

EDIT:

Looks like focus is already being called, so not sure why it doesn't work. I tried adding a setTimeout and it works, so I suspect a race condition.

Originally posted by @gosukiwi in https://github.com/atom/settings-view/issues/1083#issuecomment-703050204