Open icecream17 opened 2 years ago
In https://github.com/atom/atom/pull/22717, using marked version 1.2.0 worked, but 1.2.9 doesn't.
1.2.0
1.2.9
The fail appears to be from here:
Therefore the current version range ^1.2.0 includes the incompatible version 1.2.9. Maybe it should read 1.2.0 instead, but ideally more tests with different versions would be done to see the actual range of compatibility
^1.2.0
https://github.com/atom/settings-view/blob/d474e701bc17eebd28a732b734f7fa61b4a75553/package.json#L27
Expected behavior:
Marked 1.2.9 works
Actual behavior:
It fails
Reproduces how often:
2/2
Atom uses settings-view v0.261.8
The tests (see https://github.com/atom/atom/pull/22717#issuecomment-880848187) only fail in MacOS. Weird.
Prerequisites
Description
In https://github.com/atom/atom/pull/22717, using marked version
1.2.0
worked, but1.2.9
doesn't.The fail appears to be from here:![image](https://user-images.githubusercontent.com/58114641/125832726-4b0fd02e-eeab-4990-bfc6-4e2586312c71.png)
Therefore the current version range
^1.2.0
includes the incompatible version1.2.9
. Maybe it should read1.2.0
instead, but ideally more tests with different versions would be done to see the actual range of compatibilityhttps://github.com/atom/settings-view/blob/d474e701bc17eebd28a732b734f7fa61b4a75553/package.json#L27
Steps to Reproduce
Expected behavior:
Marked
1.2.9
worksActual behavior:
It fails
Reproduces how often:
2/2
Versions
Atom uses settings-view v0.261.8
The tests (see https://github.com/atom/atom/pull/22717#issuecomment-880848187) only fail in MacOS. Weird.
Additional Information