atom / settings-view

🔧 Edit Atom settings
MIT License
273 stars 275 forks source link

marked `1.2.9` might be incompatible #1189

Open icecream17 opened 2 years ago

icecream17 commented 2 years ago

Prerequisites

Description

In https://github.com/atom/atom/pull/22717, using marked version 1.2.0 worked, but 1.2.9 doesn't.

The fail appears to be from here: image

Therefore the current version range ^1.2.0 includes the incompatible version 1.2.9. Maybe it should read 1.2.0 instead, but ideally more tests with different versions would be done to see the actual range of compatibility

https://github.com/atom/settings-view/blob/d474e701bc17eebd28a732b734f7fa61b4a75553/package.json#L27

Steps to Reproduce

Expected behavior:

Marked 1.2.9 works

Actual behavior:

It fails

Reproduces how often:

2/2

Versions

Atom uses settings-view v0.261.8

The tests (see https://github.com/atom/atom/pull/22717#issuecomment-880848187) only fail in MacOS. Weird.

Additional Information