atom / settings-view

🔧 Edit Atom settings
MIT License
272 stars 276 forks source link

Feature request: Allow custom icons/images for packages #438

Open indiejames opened 9 years ago

indiejames commented 9 years ago

Currently packages use the authors' Github avatars for the icon/image in the package list. It would be better if the package author could specify an image.

thedaniel commented 9 years ago

Thanks for the feature request - this isn't a high priority (and I'm :-1: by default on anything that adds interface elements until persuaded otherwise) but I'll leave this issue open for discussion.

For what it's worth, if we did do this I think that the best experience would probably involve adding something nice on atom.io for image picking and cropping rather than adding another package.json field (we want to be conservative about adding fields there).

indiejames commented 9 years ago

I would probably lean toward something simpler like having a prescribed file name/format/resolution at the top of the project. Something like icon.png (128x128) or similar.

simurai commented 9 years ago

I wonder what would be shown if a package wouldn't add a custom icon? I guess there could be a generic "placeholder" icon? But that doesn't look good if there is a lot of them.

Maybe another option would be to generate some kind of unique placeholder icon. Just so it doesn't look all the same. Something like this:

screen shot 2015-03-21 at 5 45 50 pm

Because thinking about it, I have a feeling that for most packages, it won't be easy to find a good icon and not every package author has some graphic design skills to create their own custom one.

izuzak commented 9 years ago

Maybe another option would be to generate some kind of unique placeholder icon. Just so it doesn't look all the same.

Great idea :+1:, something like identicons maybe? (but different): https://github.com/blog/1586-identicons

simurai commented 9 years ago

Right, like the identicons. Well, what I actually wanted to say: We should only consider adding package icons if we're confident that most packages will add a custom icon. The generated placeholders should only be as fallback for a few exceptions, not for the majority.

braver commented 9 years ago

I dunno, I really like the current method of using the avatars. It really humanises the effort that went into every package: someone made this. De-humazing it with generated nonsense like the identicons and google-style-letters to me really clashes with the Github community feel. It just ends up as a list of colour splotches that don't tell you anything. Instead just look at this discussion, or the list of packages you've got installed, or package lists on atom.io: there are all these people creating and contributing stuff. I'd add more avatars (like for all contributors of a package) rather taking any away.

So I'd say definitely default to the avatars. Now, if some package would define an icon in the package.json or something, you could take that. I could think of something cool for the Zen package for instance. But it shouldn't be the primary mode and I can definitely agree with @thedaniel on making it low priority: it's pretty awesome as is.

simurai commented 9 years ago

It really humanises the effort that went into every package

:+1: I was more thinking in addition and not replacing the current avatars.. something like:

package-icon

But I have a feeling that most packages won't add a custom icon and it will look less nice with a lot of "placeholder" or generated icons.

Now, if some package would define an icon in the package.json or something, you could take that.

That would be another option, but it might also be strange.. some having "graphical icons" and others with human faces.

ok.. I agree keeping it as low priority.

braver commented 9 years ago

Oh right, that makes sense, sorry for not getting that. Still though, you're right: unless everyone makes awesome icons this just dilutes everything.

On 23 mrt. 2015, at 23:54, simurai notifications@github.com wrote:

It really humanises the effort that went into every package

I was more thinking in addition and not replacing the current avatars.. something like:

But I have a feeling that most packages won't add a custom icon and it will look less nice with a lot of "placeholder" or generated icons.

Now, if some package would define an icon in the package.json or something, you could take that.

That would be another option, but it might also be strange.. some having "graphical icons" and others with human faces.

ok.. I agree keeping it as low priority.

— Reply to this email directly or view it on GitHub.

abe33 commented 9 years ago

It really humanises the effort that went into every package: someone made this. De-humazing it with generated nonsense like the identicons and google-style-letters to me really clashes with the Github community feel

But I have a feeling that most packages won't add a custom icon and it will look less nice with a lot of "placeholder" or generated icons.

Same feelings here, If really a package needs a different visual identity than its primary author, then maybe he can use Github organization as a workaround (like it's already done with atom-minimap and atom-community orgs).