filePath should be escaped for markdown in notifications

[ruv]

File name can be shown incorrectly in notification. The sequence \. is turned into . — for example, it is read as "\Users\user.atom\packages" instead of "\Users\user.atom\packages".

The issue is that atom.notifications.addError function interprets message as in Markdown markup. So, filePath should be properly escaped in a code like:

atom.notifications?.addError("Failed to load snippets from '#{filePath}'", {detail: error.message, dismissable: true})

[izuzak]

@ruv Thanks for the report. I'm guessing you wanted to open this issue on this repository instead https://github.com/atom/notifications? If that's so, could you close this one and reopen over there?

[ruv]

Although, the better way is to solve the issue via additional option, something like

atom.notifications?.addError("Failed to load snippets from '#{filePath}'", {detail: error.message, dismissable: true, contenttype: 'text/plain' })

PS @izuzak, I think that I have opened the issue in the right place.

[izuzak]

Ahhh, thanks for clarifying, @ruv -- it seemed you were making a general observation, because that pattern is used in some other packages, I believe.

[izuzak]

@benogle should we try and update all such calls we have in all packages or is there a smarter way to approach this? :thought_balloon:

[benogle]

We could escape the path before making it into the notification

[ruv]

@izuzak, regarding a smarter way... Maybe it is reasonable to set default contenttype option value to text/plain in Notification constructor in case if it is known that Markdown is never used in a message text that is dispatched via atom.notifications.*