Closed layonferreira closed 5 years ago
Looks like there's solid support for this change. If you can address @50Wliu's feedback we'll get this merged.
Sure, I will fix the issues after work.
Should snippets be disabled by default?
@danielbayley I'm not too sure about that since it would change current behaviour that people are used to. I believe that this should be introduced as an option to disable and not as an option to enable. Maybe in the future, if most people are disabling them it would make sense to have it disabled by default.
Well, it seems that my pr made the specs flicky I will close this PR until I fix it
We're 👍 on the functionality, @Ben3eeE is going to review and help get this merged.
Thank you for your review, I will look into reimplementing this over the next week. update: I'm not having time to dedicate to this issue right now. if anyone else wants to implement the changes that @Ben3eeE suggested, go ahead :)
This is a continuation of #196 I have added snippets reloading without the need to restart the editor. It fixes issue #55
Supersedes and closes #196 Fixes #55