Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
This PR stops the loading of a snippets file if duplicate keys are encountered. As duplicate keys are always a mistake, it makes sense to show an error.
Alternate Designs
Only user snippets should be checked for duplicate keys. Though if all snippets are checked, it's a good way to "shame" package authors into fixing their snippets file (such as core's language-sass). The downside is more issues on atom/atom though as people copy/paste the error into a new issue.
Requirements
Description of the Change
This PR stops the loading of a snippets file if duplicate keys are encountered. As duplicate keys are always a mistake, it makes sense to show an error.
Alternate Designs
Only user snippets should be checked for duplicate keys. Though if all snippets are checked, it's a good way to "shame" package authors into fixing their snippets file (such as core's language-sass). The downside is more issues on atom/atom though as people copy/paste the error into a new issue.
Benefits
Visible error with duplicate keys
Possible Drawbacks
See alternate designs above.
Applicable Issues
Fixes #72