Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
Before, loaded was a global variable. This meant that once it was set to true it would stay true forever, even after deactivating and reactivating snippets. This PR changes it to an instance variable so that its state is reset correctly across activations.
Alternate Designs
None.
Benefits
This makes the bundledSnippetsLoaded method of provideSnippets() much more reliable, as previously it would return the wrong value if snippets was deactivated then reactivated.
Possible Drawbacks
None.
Applicable Issues
Refs atom/settings-view#998, in which I have been experimenting with using bundledSnippetsLoaded.
Requirements
Description of the Change
Before,
loadedwas a global variable. This meant that once it was set to true it would stay true forever, even after deactivating and reactivating snippets. This PR changes it to an instance variable so that its state is reset correctly across activations.Alternate Designs
None.
Benefits
This makes the
bundledSnippetsLoadedmethod ofprovideSnippets()much more reliable, as previously it would return the wrong value if snippets was deactivated then reactivated.Possible Drawbacks
None.
Applicable Issues
Refs atom/settings-view#998, in which I have been experimenting with using
bundledSnippetsLoaded.