search

atom / snippets

Atom snippets package
MIT License
205 stars 101 forks source link

package: adopt prettier-standard style #310

Open fluvf opened 4 years ago

fluvf commented 4 years ago

Description of the Change

Installs and converts the package to prettier-standard style. This is consistent with atom core, which also seems to use a custom prettier standard combo

While we're at it, also update dependencies and do some other maintenance around package.json, see commit messages for details.

The failing test also fails on master

Alternate Designs

We could copy the formatting and linting configs from atom core, but they seem unfinished and the overall setup more complex

Benefits

This will help catch any errors in, and keep the style consistent of, any new code.

Possible Drawbacks

N/A

Applicable Issues

N/A

Aerijo commented 4 years ago

The main repo uses Prettier, it would be best to be consistent with that. This is the Prettier config.

fluvf commented 4 years ago

Thanks! I'll convert this pr to use prettier when i get the chance

fluvf commented 4 years ago

I've now added prettier formatting