atom / spell-check

Spell check Atom package
MIT License
204 stars 121 forks source link

Added the ability to show loading errors as a transient popup. #247

Closed dmoonfire closed 6 years ago

dmoonfire commented 6 years ago

Description of the Change

To make it easier to identify quickly there are problems loading a system dictionary, some sort of notification would be helpful. Having a list of all the paths searched would also make it easier in the process of implementing/using relative paths for dictionaries. This patch is to have a popup show on loading errors to let the user know there is a problem and some diagnostics information.

Alternate Designs

I considered only reporting the paths to the console but it felt like it was an easily hidden spot that made it difficult to identify where the problem was happening.

Benefits

The user will be able to identify loading or locale errors sooner.

Possible Drawbacks

If they have a lot of locales and a poor location, this will cause a wall of red.

Applicable Issues

dmoonfire commented 6 years ago

This is how the popup looks:

image

dmoonfire commented 6 years ago

I'm not going to bump up the version until end of week since I'm hoping to get a number of other PRs in.