atom / spell-check

Spell check Atom package
MIT License
204 stars 121 forks source link

Spell check issue across multiple lines #313

Closed saivan closed 5 years ago

saivan commented 5 years ago

Prerequisites

Description

The spell check goes wrong and it's highlighting the whole line. This happens really frequently.

Steps to Reproduce

Just type the following into atom (I set it to safe mode just to be sure)

image

Expected behavior:

There are no spelling mistakes so I don't expect the red underlines.

Actual behavior:

Red underlines

Reproduces how often:

Always for this sentence, but its difficult to tell which sentences are causing this.

Versions

Atom : 1.39.1 Electron: 3.1.10 Chrome : 66.0.3359.181 Node : 10.2.0

I'm on macOS Mojave (10.14.5)

rsese commented 5 years ago

Thanks for the report! I can reproduce with 1.41.0-nightly3 on macOS 10.14.6.

I noticed that it seems like the last newline is related? When I remove the newline, the last sentence is no longer marked as misspelled:

spellcheck

Similarly, if I leave the newline at the end of the file, removing the period at the end of the second sentence also unmarks the misspellings.

saivan commented 5 years ago

I don't know if it is. But I can say that I see it happen in the middle of files as well

saivan commented 5 years ago

Could be related to #281 perhaps. I can't see why it flags the whole line

rsese commented 5 years ago

Could be related to #281 perhaps. I can't see why it flags the whole line

Oh yeah :+1: Didn't see that issue, this seems really similar - I think we can close in favor of that issue for now and I'll mention it to the team. If the issues are different, we can always reopen.