atom / spell-check

Spell check Atom package
MIT License
205 stars 133 forks source link

Decaffinate project into Javascript #344

Closed dmoonfire closed 3 years ago

dmoonfire commented 3 years ago

Description of the Change

While the tests had already been converted from Coffescript to Javascript but the main library was still Coffescript. This PR migrates everything else to Javascript. It also added Prettier and Husky to ensure consistent formatting.

Alternate Designs

The alternative is to keep it Coffeescript. This PR was created because it seems like Atom is moving toward Javascript and it requires only one language to develop.

Benefits

Possible Drawbacks

Applicable Issues

dmoonfire commented 3 years ago

I have a bit of code clean up that I missed (decaffinate comments).

dmoonfire commented 3 years ago

Okay, everything is cleaned up. It's ready for review and works through my test cases.

@lkashef, would you be a good person to start looking at this for me?

9994444ggg commented 3 years ago

Thank You for write me

the-j0k3r commented 3 years ago

This is a great step, so congrats. Was the coffeelint.json removed? Its should have been removed but cant see where the deletion is.

dmoonfire commented 3 years ago

Was the coffeelint.json removed? Its should have been removed but cant see where the deletion is.

I missed that, thank you, @the-j0k3r. I force pushed the commit to include it.

dmoonfire commented 3 years ago

@sadick254, I fixed the conflicts from the last release on this.