Add enableDebug to config - Githubissues

atom / spell-check

Spell check Atom package

MIT License

204 stars 121 forks source link

Add enableDebug to config #357

Closed aminya closed 3 years ago

aminya commented 3 years ago

Description of the Change

Makes debug loading lazy and hides it behind a setting. This is inline with Atom's snapshot system
This adds a config which allows to enable or disable debug

Alternate Designs

Benefits

Allows spell-check to be included in the snapshot -> Unblocks https://github.com/atom/atom/pull/21777
Adding UI for debugging makes it easier for normal users to enable/disable debugging.
No extra overhead because of debug package.
Loading time is decreased from 29ms to 15ms

Possible Drawbacks

N/A

Applicable Issues

Fixes #356

aminya commented 3 years ago

@sadick254 This probably unblocks Electron upgrade