search

atom / symbols-view

Jump to symbols in Atom
MIT License
164 stars 114 forks source link

More resilient spec #131

Closed as-cii closed 8 years ago

as-cii commented 8 years ago

Closes #128

I have seen these specs failing a bunch of times on atom/atom, and they almost always seem false positives. This PR spies upon SymbolsView::setLoading instead of checking for ::loading visibility: the problem with using toBeVisible() is that, whenever loading is faster than our test code, the assertion will get executed after loading has been already hidden, thus making the tests fail.

I'll give them a couple of spins on Travis to see whether or not this fixes it. If after 5 times it's always green, I'll go on and :ship: this.

as-cii commented 8 years ago

On a side note, you can trigger this behavior on your machine by using the good ol' stress:

stress --io 8 --cpu 8

Travis seems to always be :green_heart: now. I'll :shipit: this and bump the patch version.

/cc: @atom/feedback

maxbrunsfeld commented 8 years ago

:ok_hand: Thanks for fixing that @as-cii