atom / symbols-view

Jump to symbols in Atom
MIT License
165 stars 115 forks source link

ctrl+r can not only catch php function #192

Closed godcong closed 7 years ago

godcong commented 7 years ago

Steps to Reproduce

[First Step]

open a php file

<?php

namespace App\Jobs;

use Illuminate\Bus\Queueable;

abstract class Job { /* -------------------------------------------------------------------------- Queueable Jobs
This job base class provides a central location to place any logic that
is shared across all of your jobs. The trait included with the class
provides access to the "onQueue" and "delay" queue helper methods.
*/
use Queueable;

} [Second Step] press Ctrl+R want jump into a function [and so on...] displayed content is:

/----------- / Job / Line:7 /----------- / providers / Line:14 /-----------/ Expected behavior: [What you expected to happen] no data displayed or only class name displayed

Actual behavior: [What actually happened] a comment displayed

/----------- / providers / Line:14 /-----------/ Versions atom 1.9.7 both in: atom 1.11.0beta0 symbols-view 0.113.1 file code type: crlf utf-8 php i used an us keyboard

anotherZero commented 7 years ago

I have a similar disappointment when using ctrl+r in that it finds ALL symbols, instead of just functions (at least in php files). It would be nice to have some control over this behavior.

mcdado commented 7 years ago

Probably duplicate of https://github.com/atom/symbols-view/issues/175.

Ben3eeE commented 7 years ago

Thanks @mcdado, closing as a duplicate of #175