atom / symbols-view

Jump to symbols in Atom
MIT License
163 stars 114 forks source link

Improve JS method regex in ctags config #199

Closed nathansobo closed 7 years ago

nathansobo commented 7 years ago

This allows function calls as default parameter values by loosening the regex to allow closing parentheses within a method parameter list. Can't think of how this would create false positives so we'll give this a try.

It also excludes switch and with flow control constructs from being matched as if they were methods.

maxbrunsfeld commented 7 years ago

Waiting on review from @50Wliu.

50Wliu commented 7 years ago

Turns out I was thinking of a different but visually similar regex. I don't see any problems with this one.