atom / symbols-view

Jump to symbols in Atom
MIT License
165 stars 115 forks source link

Translate package from CoffeeScript to ES6 #203

Closed joefitzgerald closed 7 years ago

joefitzgerald commented 7 years ago

This PR translates all CoffeeScript to ES6, and makes use of the fbjs eslint preset.

/cc @zmb3

Translation Procedure

joefitzgerald commented 7 years ago

/cc @atom/maintainers This is ready for review. 👀

maxbrunsfeld commented 7 years ago

I think we can probably get rid of BaseSymbolsView, and have SymbolsView inherit directly from atom-space-pen-views. Other than that, this looks great. Thanks for the great writeup of your conversion procedure.

joefitzgerald commented 7 years ago

:shipit:

maxbrunsfeld commented 7 years ago

Thanks @joefitzgerald!