Closed joefitzgerald closed 7 years ago
/cc @atom/maintainers This is ready for review. 👀
I think we can probably get rid of BaseSymbolsView
, and have SymbolsView
inherit directly from atom-space-pen-views
. Other than that, this looks great. Thanks for the great writeup of your conversion procedure.
:shipit:
Thanks @joefitzgerald!
This PR translates all CoffeeScript to ES6, and makes use of the
fbjs
eslint preset.devDependencies
foreslint
/fbjs
/cc @zmb3
Translation Procedure
npm install -g decaffeinate
linter-eslint
and enable--fix
on save.eslintrc.js
/.eslintignore
are configured correctlydecaffeinate <path to the .coffee file
.js
file in atom.js
file'use babel';
at the first line of the filelet
>const
where possibleif (theThing == null)
becomeif (!theThing)
guard
/guardFunc
with plain inline ES6function () { }
with() => { }
where appropriatereturn
statements arising from implicit returns in CoffeeScript.coffee
file