search

atom / symbols-view

Jump to symbols in Atom
MIT License
163 stars 114 forks source link

Switch from fbjs to standard #206

Closed joefitzgerald closed 7 years ago

joefitzgerald commented 7 years ago

This PR switches from FBJS > Standard.

Rationale:

./node_modules/.bin/standard --fix
standard: Use JavaScript Standard Style (http://standardjs.com)
  /Users/joe/github/symbols-view/lib/tag-generator.js:98:19: Expected a conditional expression and instead saw an assignment.
  /Users/joe/github/symbols-view/lib/tag-reader.js:27:9: Expected a conditional expression and instead saw an assignment.
  /Users/joe/github/symbols-view/lib/tag-reader.js:38:45: '?' should be placed at the beginning of the line.
  /Users/joe/github/symbols-view/lib/tag-reader.js:43:8: Bad line breaking before and after ':'.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:43:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:69:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:106:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:154:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:174:63: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:191:63: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:459:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:505:14: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:525:16: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:589:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:610:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:630:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:660:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:680:12: Arrow function should not return assignment.
  /Users/joe/github/symbols-view/spec/symbols-view-spec.js:707:12: Arrow function should not return assignment.

See also: https://github.com/facebook/fbjs/issues/211 See also: https://github.com/facebook/fbjs/issues/210

Both of which have had no response in one / two weeks respectively.

https://github.com/facebook/fbjs#purpose

Note: If you are consuming the code here and you are not also a Facebook project, be prepared for a bad time. APIs may appear or disappear and we may not follow semver strictly, though we will do our best to. This library is being published with our use cases in mind and is not necessarily meant to be consumed by the broader public. In order for us to move fast and ship projects like React and Relay, we've made the decision to not support everybody. We probably won't take your feature requests unless they align with our needs. There will be overlap in functionality here and in other open source projects.

nathansobo commented 7 years ago

I'd like to hold off on this until we talk to the Nuclide team next Monday. If we can bundle the dependencies to make this more convenient then I think we could be in okay shape. Are there any outstanding logistical issues other than that you'd like us to negotiate?

joefitzgerald commented 7 years ago

In the past few days I've found that fbjs/opensource (as opposed to fbjs) is a preferable alternative, that we're not using in symbols-view currently.

Switching to fbjs/opensource and then having the peerDependencies bundled as actual dependencies would obviate this PR.

nathansobo commented 7 years ago

Switching to fbjs/opensource and then having the peerDependencies bundled as actual dependencies would obviate this PR.

Cool. We'll talk to them about bundling the dependencies.