atom / symbols-view

Jump to symbols in Atom
MIT License
165 stars 115 forks source link

Filters symbols based on selected text #214

Closed sanketh95 closed 7 years ago

sanketh95 commented 7 years ago

Requirements

Description of the Change

Filter symbols based on selected text. This is pretty handy feature to avoid doing ctrl-c -> ctrl-r -> ctrl-v. If there are multiple selections or multi-line selections, we ignore the selection and fallback to the default of expecting user input.

Alternate Designs

N/A

Benefits

Avoids the unnecessary overhead of having to do ctrl-c -> ctrl-r -> ctrl-v. Maintains consistency in the way searches are done. For example, the standard search bar (ctrl + f) exhibits this behavior.

Possible Drawbacks

None that I see.

Applicable Issues

None that I see

sanketh95 commented 7 years ago

There seem to be a few tests breaking. I will close this pull request and raise one once I make sure the tests run fine.