search

atom / symbols-view

Jump to symbols in Atom
MIT License
165 stars 115 forks source link

If present, use tag line number instead of search pattern. #229

Closed segevfiner closed 6 years ago

segevfiner commented 6 years ago

Requirements

Description of the Change

Line numbers are emmited by ctags, by default, in some cases. This is true for C preprocessor macros, for example. So properly handle them.

The user can request not to emit them (The --excmd argument to ctags, and short forms of it) but it's best for Atom to handle this correctly since this is part of the documented syntax of ctags.

Original by: @raphinesse (PR #187). This is an updated version of that PR to ES6 from CoffeeScript + Minor Changes. Hope you don't mind 😉.

Benefits

symbols-view will properly work with tags files that contain line number references. For example references to C/C++ macros.

Supersedes and closes https://github.com/atom/symbols-view/pull/187

raphinesse commented 6 years ago

As long as my original authorship is mentioned in the commit or something like that, I'm completely fine with my code being recycled.

I just sincerely hope for you that this PR will not share the fate of my original one. Open source projects that do not honor contributions really annoy me.

rsese commented 6 years ago

Sorry about your original pull request @raphinesse, we really do appreciate help from the community. Additionally, I wanted to let you know that we've tweaked our process to better track and bring PRs up for discussion so they're less likely to fall through the cracks. Thanks again for your contributions :bow:

Ben3eeE commented 6 years ago

@segevfiner Can you look at the travis failure?

raphinesse commented 6 years ago

@rsese Glad to hear that. Looking forward to seeing this getting merged.

segevfiner commented 6 years ago

@Ben3eeE Travis now passes.

Ben3eeE commented 6 years ago

@segevfiner Great :100: I added this PR to the project board.

maxbrunsfeld commented 6 years ago

💯 Great work @raphinesse and @segevfiner; thanks for the contribution!

maxbrunsfeld commented 6 years ago

This will go out in Atom 1.22.