droopy4096 commented 5 years ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

currently symbols-view has a special case for ruby notation (':'-separated) however it fails with Puppet notation ('::') - ruby's solution has been extended to provide puppet support

Alternate Designs

Alternatively there should be a map of language and word separators that could be extended by user. but implementation of such feature is beyond my current abilities in JS

Benefits

Puppet ctags will work as expected

Possible Drawbacks

none

Applicable Issues

244

rsese commented 5 years ago

Thanks for the contribution @droopy4096! Can you checkout my question in the issue you opened /cc https://github.com/atom/symbols-view/issues/244#issuecomment-465842305?

Also, as mentioned in the Requirements section above, the team will need tests to be added before they can review and tests will help guard against future changes breaking your work :smile: