"No symbols found" for plsql sytanx with extension not ".sql"

jpromocion commented 5 years ago

Only in extension ".sql" files.... It works CTRL+R. Extensions: "pks", "pkb" (language-oracle package).. not works

Version: 1.35.1

I read "https://github.com/atom/symbols-view/pull/134", but right now... not work.

NOTE: symbols-tree-view shows them

rsese commented 5 years ago

Thanks for the report! Can you fill out the issue template? The information in the template is super helpful for us when triaging issues. In particular, a sample file and specific steps to reproduce would be helpful.

jpromocion commented 5 years ago

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Only in extension ".sql" files.... It works CTRL+R. Extensions: "pks", "pkb" (language-oracle package).. not works I read "#134", but right now... not work.

Steps to Reproduce

File for "CREATE OR REPLACE PACKAGE BODY xxx", extension ".pkb"
Open with Atom, with plugin language-oracle -> "PL/SQL (Oracle)". Last version -> "file-types" are not fill.
CTRL+R (windows) -> "No symbols found".
Copy this file, but rename with extension ".sql".
Open with Atom file ".sql" -> language "PL/SQL (Oracle)".
CTRL+R (windows) -> Symbols are correct and i can search.

Expected behavior: [What you expect to happen] CTRL+R search symbols for all file extensions of language "PL/SQL (Oracle)": .pks, .pkb, .vw, .plb

Actual behavior: [What actually happens] There is symbols with file extension ".sql".

Reproduces how often: [What percentage of the time does it reproduce?] Always.

Versions

S.O.: Windows 10 Pro. 64 bits. Atom: Atom: 1.35.1 Electron: 2.0.18 Chrome: 61.0.3163.100 Node: v8.9.3 apm --version: apm 2.1.3 npm 6.2.0 node 8.9.3 x64 atom 1.35.1 python 3.7.3 git 2.21.0.windows.1 visual studio

Additional Information

Install plugin "language-oracle" --> syntax "PL/SQL (Oracle)"

rsese commented 5 years ago

Sorry for the delay - I wasn't able to reproduce with a file with just the content you mentioned in step 1 (not sure if I misunderstood that step):

CREATE OR REPLACE PACKAGE BODY xxx

But I was able to get a symbol (message) showing for this example in the .sql file:

DECLARE 
   message  varchar2(20):= 'Hello, World!'; 
BEGIN 
   dbms_output.put_line(message); 
END;

But there was no symbol for the .pkb version.

If you create a ~/.ctags file with this content, does that get things working for you?

--langmap=Sql:+.pkb

jpromocion commented 5 years ago

Don't worry. Full example:

CREATE OR REPLACE PACKAGE BODY paquete IS

  FUNCTION function1 (param NUMBER) IS
  RETURN NUMBER
  BEGIN
    RETURN NULL;
  END function1;

  PROCEDURE procedure1() IS
  BEGIN

  END procedure1;

END paquete;
/

2 symbol: "function1" and "procedure1" in file ".sql". No symbol in file ".pkb".

But, you are right, if I create a "~/.ctags" with this content.... work!!!

Thank you

atom / symbols-view